mlbiscoc opened a new pull request, #3344: URL: https://github.com/apache/solr/pull/3344
https://issues.apache.org/jira/browse/SOLR-17756 # Description The index fingerprint is currently being calculated on each segment sequentially. While this works fine, the index fingerprint calculation was noticed to be a very slow process and on leader election is blocking. This proposes to have this calculation parallelized across segments instead. Since the fingerprint is just a cumulative sum of a hash on versions, the order in which it is added to the running sum should not matter. # Solution Create a dedicated threadpool (`IndexFingerprintPool`) to calculate the indexfingerprint. Created a separate theadpool instead of the common `ForkJoinPool` as this can be an expensive operation calculating across a large index # Tests Created `testSequentialVsParallelFingerprint` test to confirm the fingerprint is the same. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
