psalagnac commented on code in PR #3344:
URL: https://github.com/apache/solr/pull/3344#discussion_r2087212237


##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -449,6 +456,10 @@ public CoreContainer(NodeConfig config, CoresLocator 
locator, boolean asyncSolrC
     this.allowListUrlChecker = AllowListUrlChecker.create(config);
 
     this.indexSearcherExecutor = SolrIndexSearcher.initCollectorExecutor(cfg);
+
+    this.indexFingerprintExecutor =
+        ExecutorUtil.newMDCAwareFixedThreadPool(

Review Comment:
   Can't we have lazily initialized threads instead for memory saving? My 
understanding is they will no be used most of the time.
   
   This can be achieved with
   ```
    ExecutorUtil.newMDCAwareCachedThreadPool(
               EXECUTOR_MAX_CPU_THREADS, Integer.MAX_VALUE, ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to