epugh commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r2095761990


##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -55,6 +50,8 @@ public class SolrClientCache implements Closeable {
   private static final int minSocketTimeout =
       Math.max(Integer.getInteger(HttpClientUtil.PROP_SO_TIMEOUT, 
MIN_TIMEOUT), MIN_TIMEOUT);
 
+  private String basicAuthCredentials = null; // Only support with the 
http2SolrClient

Review Comment:
   I could get behind that.  It's not always obvious which settings are done on 
the http client level and which are at the solr level ;-).   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to