dsmiley commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r2097944163
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -55,6 +50,8 @@ public class SolrClientCache implements Closeable {
private static final int minSocketTimeout =
Math.max(Integer.getInteger(HttpClientUtil.PROP_SO_TIMEOUT,
MIN_TIMEOUT), MIN_TIMEOUT);
+ private String basicAuthCredentials = null; // Only support with the
http2SolrClient
Review Comment:
> It's not always obvious which settings are done on the http client level
and which are at the solr level ;-).
Hmm; I'm not sure how that's relevant to this situation. If you create an
Http2SolrClient (with basic auth and whatever else) and pass it to
SolrClientCache, it'll be used completely not partially.
I'm marking this setter deprecated in an upcoming PR loosely related to at
least signal we don't want this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
