alessandrobenedetti commented on code in PR #3354:
URL: https://github.com/apache/solr/pull/3354#discussion_r2096070276
##########
solr/modules/ltr/src/test/org/apache/solr/ltr/TestSelectiveWeightCreation.java:
##########
@@ -142,7 +142,10 @@ public void testScoringQueryWeightCreation() throws
IOException, ModelException
assertEquals("11",
searcher.storedFields().document(hits.scoreDocs[1].doc).get("id"));
List<Feature> features = makeFeatures(new int[] {0, 1, 2});
+ List<Feature> expectedNotDefaultFeatures = makeFeatures(new int[] {1, 2});
Review Comment:
NotDefault -> NonDefault
##########
solr/modules/ltr/src/test/org/apache/solr/ltr/TestSelectiveWeightCreation.java:
##########
@@ -142,7 +142,10 @@ public void testScoringQueryWeightCreation() throws
IOException, ModelException
assertEquals("11",
searcher.storedFields().document(hits.scoreDocs[1].doc).get("id"));
List<Feature> features = makeFeatures(new int[] {0, 1, 2});
+ List<Feature> expectedNotDefaultFeatures = makeFeatures(new int[] {1, 2});
final List<Feature> allFeatures = makeFeatures(new int[] {0, 1, 2, 3, 4,
5, 6, 7, 8, 9});
+ List<Feature> expectedNotDefaultAllFeatures =
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
