aruggero commented on code in PR #3354:
URL: https://github.com/apache/solr/pull/3354#discussion_r2097236815


##########
solr/modules/ltr/src/test/org/apache/solr/ltr/feature/TestFieldValueFeature.java:
##########
@@ -250,6 +250,31 @@ public void 
testIfADocumentDoesntHaveAFieldDefaultValueIsReturned() throws Excep
     assertJQ("/query" + query.toQueryString(), "/response/numFound/==1");
     assertJQ("/query" + query.toQueryString(), "/response/docs/[0]/id=='42'");
 
+    final String docs0fv_dense_csv =

Review Comment:
   This is needed since, depending on the sparse/dense format, we could have 
default values to be returned.
   Before the bug fix, zero values were returned even with the sparse format.
   With these changes, we are aligning the expected output of the tests to the 
randomly selected feature format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to