dsmiley commented on code in PR #3355:
URL: https://github.com/apache/solr/pull/3355#discussion_r2105036268
##########
solr/core/src/java/org/apache/solr/cli/StatusTool.java:
##########
@@ -314,12 +314,12 @@ public static Map<String, Object>
reportStatus(NamedList<Object> info, SolrClien
String solrHome = (String) info.get("solr_home");
status.put("solr_home", solrHome != null ? solrHome : "?");
- status.put("version", info.findRecursive("lucene", "solr-impl-version"));
- status.put("startTime", info.findRecursive("jvm", "jmx",
"startTime").toString());
- status.put("uptime", SolrCLI.uptime((Long) info.findRecursive("jvm",
"jmx", "upTimeMS")));
+ status.put("version", info._get(List.of("lucene", "solr-impl-version"),
null));
+ status.put("startTime", info._get(List.of("jvm", "jmx", "startTime"),
null).toString());
Review Comment:
these two can be `_getStr`
##########
solr/core/src/java/org/apache/solr/cli/StatusTool.java:
##########
@@ -314,12 +314,12 @@ public static Map<String, Object>
reportStatus(NamedList<Object> info, SolrClien
String solrHome = (String) info.get("solr_home");
status.put("solr_home", solrHome != null ? solrHome : "?");
- status.put("version", info.findRecursive("lucene", "solr-impl-version"));
- status.put("startTime", info.findRecursive("jvm", "jmx",
"startTime").toString());
- status.put("uptime", SolrCLI.uptime((Long) info.findRecursive("jvm",
"jmx", "upTimeMS")));
+ status.put("version", info._get(List.of("lucene", "solr-impl-version"),
null));
+ status.put("startTime", info._get(List.of("jvm", "jmx", "startTime"),
null).toString());
+ status.put("uptime", SolrCLI.uptime((Long) info._get(List.of("jvm", "jmx",
"upTimeMS"), null)));
- String usedMemory = (String) info.findRecursive("jvm", "memory", "used");
- String totalMemory = (String) info.findRecursive("jvm", "memory", "total");
+ String usedMemory = (String) info._get(List.of("jvm", "memory", "used"),
null);
+ String totalMemory = (String) info._get(List.of("jvm", "memory", "total"),
null);
Review Comment:
`_getStr`
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -862,14 +862,18 @@ public static void checkDiskSpace(
SolrRequest.METHOD.GET, "/admin/metrics",
SolrRequest.SolrRequestType.ADMIN, params)
.process(cloudManager.getSolrClient());
- Number size = (Number) rsp.getResponse().findRecursive("metrics",
indexSizeMetricName);
+ NamedList<Object> entries1 = rsp.getResponse();
Review Comment:
still an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
