dsmiley commented on code in PR #3355:
URL: https://github.com/apache/solr/pull/3355#discussion_r2110406288
##########
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##########
@@ -173,9 +173,11 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, CommandLine cli) th
solrClient.request(
new GenericSolrRequest(
SolrRequest.METHOD.GET,
CommonParams.SYSTEM_INFO_PATH));
- uptime = SolrCLI.uptime((Long) systemInfo.findRecursive("jvm",
"jmx", "upTimeMS"));
- String usedMemory = (String) systemInfo.findRecursive("jvm",
"memory", "used");
- String totalMemory = (String) systemInfo.findRecursive("jvm",
"memory", "total");
+ uptime =
+ SolrCLI.uptime((Long) systemInfo._get(List.of("jvm", "jmx",
"upTimeMS"), null));
+ String usedMemory = (String) systemInfo._get(List.of("jvm",
"memory", "used"), null);
Review Comment:
I assume you didn't finish reviewing this PR since this shows some `_getStr`
opportunities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
