kotman12 commented on PR #3356: URL: https://github.com/apache/solr/pull/3356#issuecomment-2912755279
> Looks good, thanks. Can you please add to CHANGES.txt in the improvement section? I updated the CHANGES.txt under 10 but I'm wondering if this should go out in 9.9? I'd argue this is something between a bug and an optimization since the request timeouts were added _very_ likely by accident. I've also moved the override to the recovery client. Maybe that is overkill but, again, I want to stress that until we moved to Jetty's HttpClient there was no request timeout on this _at all_. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
