mlbiscoc commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2132890849
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -423,6 +433,11 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
this.solrHome = config.getSolrHome();
this.solrCores = SolrCores.newSolrCores(this);
this.nodeKeyPair = new SolrNodeKeyPair(cfg.getCloudConfig());
+ this.prometheusMetricReader = new PrometheusMetricReader(true, null);
+ initializeOpenTelemetrySdk();
+ this.tracer = TraceUtils.getGlobalTracer();
+ this.meterProvider = MetricUtils.getMeterProvider();
Review Comment:
Thats understandable. Moved it out of `coreContainer` and into
`MetricManager` which makes the most sense. `MetricManager` creates instruments
for measuring metrics and so also putting the `MetricReader` and
`MeterProvider` in there as well was perfect.
`initializeOpenTelemetrySdk` was moved into the `OpenTelemetryConfigurator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
