janhoy commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2134845126
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -465,6 +480,39 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
new SolrNamedThreadFactory("IndexFingerprintPool"));
}
+ /**
Review Comment:
I asked for docs since there was a regression in the first pass. I agree
Javadocs primarily is for public APIs, so I'm happy if the intended order of
initialization is documented in a different way, e.g. inline the if-then-else
logic as oneline `//` comments. Just short and concise to make the flow easier
to grok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
