dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2148843025
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##########
@@ -25,6 +25,12 @@
public abstract class HttpSolrClientBuilderBase<
B extends HttpSolrClientBuilderBase<?, ?>, C extends HttpSolrClientBase> {
+ /**
+ * About 24 days in milliseconds -- basically forever to wait for something.
But not so large to
+ * cause overflow.
+ */
+ protected static final long FOREVER_MILLIS = Integer.MAX_VALUE;
Review Comment:
I'd rather not add yet another method for the ~infinite/forever case. I did
see an issue with Long.MAX_VALUE and a test failed clearly related to
overflow... if I recall it was with the JDK HttpClient. Any way, we could
ignore the matter if it doesn't show up again. If it does show up again... I
could see either switching to integer or reducing the value on `setXXX(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
