dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2159651401
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -129,6 +128,20 @@ protected Http2SolrClient(String serverBaseUrl, Builder
builder) {
super(serverBaseUrl, builder);
if (builder.httpClient != null) {
+ // Validate that no conflicting options are provided when using an
existing HttpClient
+ if (builder.followRedirects != null
+ || builder.connectionTimeoutMillis != null
+ || builder.maxConnectionsPerHost != null
+ || builder.useHttp1_1
Review Comment:
Thanks for noticing / fixing! This was gnawing me a little but I didn't see
the bug. I was tempted to use a `Boolean` and to resolve the correct choice in
a getter, like I did for the timeouts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
