dsmiley commented on code in PR #3385:
URL: https://github.com/apache/solr/pull/3385#discussion_r2162930217
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -126,16 +131,41 @@ public DocValuesFormat getDocValuesFormatForField(String
field) {
public KnnVectorsFormat getKnnVectorsFormatForField(String field) {
final SchemaField schemaField =
core.getLatestSchema().getFieldOrNull(field);
FieldType fieldType = (schemaField == null ? null :
schemaField.getType());
- if (fieldType instanceof DenseVectorField vectorType) {
+ KnnVectorsFormat delegate;
Review Comment:
`ScalarQuantizedDenseVectorField.init()` (and its subclass,
DenseVectorField) creating a `KnnVectorsFormat` that later can simply be
returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
