dsmiley commented on code in PR #3477:
URL: https://github.com/apache/solr/pull/3477#discussion_r2280658678
##########
solr/core/src/test/org/apache/solr/update/SolrIndexFingerprintTest.java:
##########
@@ -28,29 +29,21 @@ public class SolrIndexFingerprintTest extends
SolrTestCaseJ4 {
@BeforeClass
public static void beforeTests() throws Exception {
- initCore("solrconfig.xml", "schema.xml");
+ initCore("solrconfig-tiny-segments.xml", "schema.xml");
}
@Test
public void testSequentialVsParallelFingerprint() throws Exception {
long maxVersion = Long.MAX_VALUE;
SolrCore core = h.getCore();
- // Create a set of 3 segments
- assertU(adoc("id", "101"));
- assertU(adoc("id", "102"));
- assertU(adoc("id", "103"));
- assertU(commit());
-
- assertU(adoc("id", "104"));
- assertU(adoc("id", "105"));
- assertU(adoc("id", "106"));
- assertU(commit());
-
- assertU(adoc("id", "107"));
- assertU(adoc("id", "108"));
- assertU(adoc("id", "109"));
- assertU(commit());
+ // Create a set of 500 segments (to catch race conditions, i.e.SOLR-17863)
Review Comment:
Let's not repeat a constant in the code with your comment so that we don't
have to synchronize them. I suggest the word "many".
In this situation, I recommend looking to see if
org.apache.lucene.tests.util.LuceneTestCase.RANDOM_MULTIPLIER is 1 and if so
return 3 but otherwise return 500. Thus a nightly test run pushes it harder.
But maybe 500 is fast? How long does this test take at 500?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
