kotman12 commented on code in PR #3477:
URL: https://github.com/apache/solr/pull/3477#discussion_r2282726759
##########
solr/core/src/test/org/apache/solr/update/SolrIndexFingerprintTest.java:
##########
@@ -28,29 +29,21 @@ public class SolrIndexFingerprintTest extends
SolrTestCaseJ4 {
@BeforeClass
public static void beforeTests() throws Exception {
- initCore("solrconfig.xml", "schema.xml");
+ initCore("solrconfig-tiny-segments.xml", "schema.xml");
}
@Test
public void testSequentialVsParallelFingerprint() throws Exception {
long maxVersion = Long.MAX_VALUE;
SolrCore core = h.getCore();
- // Create a set of 3 segments
- assertU(adoc("id", "101"));
- assertU(adoc("id", "102"));
- assertU(adoc("id", "103"));
- assertU(commit());
-
- assertU(adoc("id", "104"));
- assertU(adoc("id", "105"));
- assertU(adoc("id", "106"));
- assertU(commit());
-
- assertU(adoc("id", "107"));
- assertU(adoc("id", "108"));
- assertU(adoc("id", "109"));
- assertU(commit());
+ // Create a set of 500 segments (to catch race conditions, i.e.SOLR-17863)
Review Comment:
It takes ~20s on my machine with 500 segments. I think nightly is
appropriate and have implemented your initial suggestion. I've also addressed
the other comments, please have another look when you get a chance 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
