mlbiscoc commented on code in PR #3516:
URL: https://github.com/apache/solr/pull/3516#discussion_r2308356000
##########
solr/core/src/test/org/apache/solr/util/stats/InstrumentedPoolingHttpClientConnectionManagerTest.java:
##########
@@ -0,0 +1,111 @@
+package org.apache.solr.util.stats;
+
+import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.exporter.prometheus.PrometheusMetricReader;
+import io.prometheus.metrics.model.snapshots.GaugeSnapshot;
+import io.prometheus.metrics.model.snapshots.Labels;
+import org.apache.http.HttpClientConnection;
+import org.apache.http.HttpHost;
+import org.apache.http.config.Registry;
+import org.apache.http.config.RegistryBuilder;
+import org.apache.http.conn.routing.HttpRoute;
+import org.apache.http.conn.socket.ConnectionSocketFactory;
+import org.apache.http.conn.socket.PlainConnectionSocketFactory;
+import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.core.SolrInfoBean;
+import org.apache.solr.metrics.SolrMetricProducer;
+import org.apache.solr.metrics.SolrMetricTestUtils;
+import org.apache.solr.metrics.SolrMetricsContext;
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import java.util.concurrent.TimeUnit;
+
+public class InstrumentedPoolingHttpClientConnectionManagerTest extends
SolrTestCaseJ4 {
+
+ private InstrumentedPoolingHttpClientConnectionManager connectionManager;
+ private PrometheusMetricReader metricsReader;
+
+ @BeforeClass
+ public static void beforeClass() throws Exception {
+ initCore("solrconfig-minimal.xml", "schema.xml");
+ h.getCoreContainer().waitForLoadingCoresToFinish(30000);
+ }
+
+ @Before
+ @Override
+ public void setUp() throws Exception {
+ super.setUp();
+ Registry<ConnectionSocketFactory > socketFactoryRegistry =
RegistryBuilder.<ConnectionSocketFactory>create()
+ .register("http", PlainConnectionSocketFactory.INSTANCE)
+ .build();
+
+ connectionManager = new
InstrumentedPoolingHttpClientConnectionManager(socketFactoryRegistry);
+
+ SolrMetricsContext solrMetricsContext = h.getCoreContainer()
+ .getMetricsHandler()
+ .getSolrMetricsContext();
+
+ Attributes attributes = Attributes.builder()
+ .put(SolrMetricProducer.CATEGORY_ATTR,
SolrInfoBean.Category.HTTP.toString())
+ .build();
+
+ connectionManager.initializeMetrics(solrMetricsContext, attributes,
"test");
+ metricsReader =
SolrMetricTestUtils.getPrometheusMetricReader(h.getCoreContainer(),
"solr.node");
+ }
+
+ @After
+ @Override
+ public void tearDown() throws Exception {
+ if (connectionManager != null) {
+ connectionManager.close();
+ }
+ super.tearDown();
+ }
+
+ @AfterClass
+ public static void afterClass() throws Exception {
+ deleteCore();
+ }
+
+ @Test
+ public void testInitializedMetrics() {
+ assertGaugeMetricValueForType("available_connections", 0);
+ assertGaugeMetricValueForType("leased_connections", 0);
+ assertGaugeMetricValueForType("pending_connections", 0);
+ // The default maximum when no configuration override is provided
+ assertGaugeMetricValueForType("max_connections", 20);
+ }
+
+ @Test
+ public void testLeasedConnectionsMetrics() throws Exception {
+ HttpRoute route = new HttpRoute(new HttpHost("localhost", 8080));
+
+ assertGaugeMetricValueForType("leased_connections", 0);
+
+ HttpClientConnection conn = connectionManager
+ .requestConnection(route, null)
+ .get(1000, TimeUnit.MILLISECONDS);
+
+ assertGaugeMetricValueForType("leased_connections", 1);
+
+ connectionManager.releaseConnection(conn, null, 0, null);
+
+ assertGaugeMetricValueForType("leased_connections", 0);
+ }
+
+ private void assertGaugeMetricValueForType(String metricType, double
expectedValue) {
+ Labels labels = Labels.builder()
+ .label("category", "HTTP")
+ .label("otel_scope_name", "org.apache.solr")
Review Comment:
Oh actually thats a good point that I forgot. Ignore this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
