dsmiley commented on code in PR #3516: URL: https://github.com/apache/solr/pull/3516#discussion_r2308387104
########## solr/core/src/test/org/apache/solr/util/stats/InstrumentedPoolingHttpClientConnectionManagerTest.java: ########## @@ -0,0 +1,84 @@ +package org.apache.solr.util.stats; + +import io.opentelemetry.exporter.prometheus.PrometheusMetricReader; +import io.prometheus.metrics.model.snapshots.GaugeSnapshot; +import io.prometheus.metrics.model.snapshots.Labels; +import org.apache.http.HttpClientConnection; +import org.apache.http.HttpHost; +import org.apache.http.conn.routing.HttpRoute; +import org.apache.solr.SolrTestCaseJ4; +import org.apache.solr.metrics.SolrMetricTestUtils; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + +import java.util.concurrent.TimeUnit; + +public class InstrumentedPoolingHttpClientConnectionManagerTest extends SolrTestCaseJ4 { + + private static InstrumentedPoolingHttpClientConnectionManager connectionManager; + private PrometheusMetricReader metricsReader; + + @BeforeClass + public static void beforeClass() throws Exception { + initCore("solrconfig-minimal.xml", "schema.xml"); + h.getCoreContainer().waitForLoadingCoresToFinish(30000); Review Comment: that's curious; did they load asynchronously? TestHarness should start CoreContainer with synchronous loading (`asyncSolrCoreLoad=false`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org