mlbiscoc commented on code in PR #3707:
URL: https://github.com/apache/solr/pull/3707#discussion_r2388008635
##########
solr/core/src/java/org/apache/solr/metrics/SolrCoreMetricManager.java:
##########
@@ -187,9 +187,6 @@ public void close() throws IOException {
}
metricManager.unregisterGauges(
solrMetricsContext.getRegistryName(), solrMetricsContext.getTag());
-
- metricManager.removeRegistry(solrMetricsContext.getRegistryName());
- registeredProducers.clear();
Review Comment:
So I think I found the culprit for reload and metrics not working correctly.
I had added to delete the registry here for OTEL metrics but Dropwizard didn't
delete the registry but instead just unregistered gauges which isn't all
metrics. So I removed this and tests all pass like normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
