dsmiley commented on code in PR #3707:
URL: https://github.com/apache/solr/pull/3707#discussion_r2392091596
##########
solr/core/src/java/org/apache/solr/metrics/SolrCoreMetricManager.java:
##########
@@ -187,9 +187,6 @@ public void close() throws IOException {
}
metricManager.unregisterGauges(
solrMetricsContext.getRegistryName(), solrMetricsContext.getTag());
-
- metricManager.removeRegistry(solrMetricsContext.getRegistryName());
- registeredProducers.clear();
Review Comment:
Are you saying that a core's metrics are mostly still accessible, even after
a core is deleted? Technically you didn't, this code is in the context of
"close"... but I'd hope that a high level command to remove/delete a core would
do similarly for the underlying metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
