gerlowskija commented on PR #3720: URL: https://github.com/apache/solr/pull/3720#issuecomment-3361589204
> Having said that, i don't know that it's worth all the effort if it's just for this specfic need. Yeah, agreed. FWIW I also took a crack at extracting the ZkController code that instantiates all these plugins into its own helper class, that could be unit tested separately. I was able to test it, but the test code involved a good bit of mocking and ended up very brittle and difficult to parse. Ended up scrapping the effort. I'm going to merge this without any automated test; if anyone has ideas for testing, please let me know here and I'll try to circle back to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
