epugh commented on code in PR #2391:
URL: https://github.com/apache/solr/pull/2391#discussion_r2434250136
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -192,9 +193,13 @@ public void initZooKeeper(final CoreContainer cc,
CloudConfig config) {
// we are ZooKeeper enabled
try {
// If this is an ensemble, allow for a long connect time for other
servers to come up
- if (zkServerEnabled && zkServer.getServers().size() > 1) {
+ if (zkServerEnabled && zkServer != null &&
zkServer.getServers().size() > 1) {
zkClientConnectTimeout = 24 * 60 * 60 * 1000; // 1 day for embedded
ensemble
log.info("Zookeeper client={} Waiting for a quorum.",
zookeeperHost);
+ } else if (zkServerEnabled && runAsQuorum) {
+ // Quorum mode also needs long timeout for other nodes to start
+ zkClientConnectTimeout = 24 * 60 * 60 * 1000; // 1 day for embedded
quorum
Review Comment:
Lovely. I think we were trying to put units in the variable names in other
places ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
