janhoy commented on code in PR #2391:
URL: https://github.com/apache/solr/pull/2391#discussion_r2435561453
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1174,16 +1379,33 @@ public MiniSolrCloudCluster build() throws Exception {
}
JettyConfig jettyConfig = jettyConfigBuilder.build();
- MiniSolrCloudCluster cluster =
- new MiniSolrCloudCluster(
- nodeCount,
- baseDir,
- solrXml,
- jettyConfig,
- null,
- securityJson,
- trackJettyMetrics,
- formatZkServer);
+ MiniSolrCloudCluster cluster;
+
+ if (useEmbeddedZkQuorum) {
Review Comment:
Hmm, this code **is** inside the builder :) So the builder chose to
instantiate the MSCC using one of two constructors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
