psalagnac commented on code in PR #3773:
URL: https://github.com/apache/solr/pull/3773#discussion_r2435638700
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java:
##########
@@ -796,4 +787,7 @@ private static void getConfName(
"Could not find configName for collection " + collection + " found:"
+ configNames);
}
}
+
+ /** Internal structure to track cores to create with the collection. */
+ private record CoreToCreate(String nodeName, ModifiableSolrParams params) {}
Review Comment:
I agree this may be too verbose. I removed it and used a simple map instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
