dsmiley commented on code in PR #3773:
URL: https://github.com/apache/solr/pull/3773#discussion_r2433862829
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java:
##########
@@ -359,19 +359,10 @@ public void call(ClusterState clusterState, ZkNodeProps
message, NamedList<Objec
if (async != null) {
String coreAdminAsyncId = async + Math.abs(System.nanoTime());
params.add(ASYNC, coreAdminAsyncId);
- shardRequestTracker.track(nodeName, coreAdminAsyncId);
}
CollectionHandlingUtils.addPropertyParams(message, params);
- ShardRequest sreq = new ShardRequest();
- sreq.nodeName = nodeName;
- params.set("qt", ccc.getAdminPath());
- sreq.purpose = ShardRequest.PURPOSE_PRIVATE;
- sreq.shards = new String[] {baseUrl};
- sreq.actualShards = sreq.shards;
- sreq.params = params;
Review Comment:
what became of this?
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java:
##########
@@ -796,4 +787,7 @@ private static void getConfName(
"Could not find configName for collection " + collection + " found:"
+ configNames);
}
}
+
+ /** Internal structure to track cores to create with the collection. */
+ private record CoreToCreate(String nodeName, ModifiableSolrParams params) {}
Review Comment:
I'm not seeing that this named structure adds any clarity, honestly. But if
you think so then ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
