mlbiscoc commented on code in PR #3734:
URL: https://github.com/apache/solr/pull/3734#discussion_r2417764630
##########
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##########
Review Comment:
Once I started migrating `DirectUpdateHandler2` this duplicate code became
way more prevalent and messy and really began to regret the paradigm I adopted
when I originally wrote this. So rewrote it with a factory. Let me know what
you think
##########
solr/core/src/test-files/solr/configsets/cloud-aggregate-node-metrics/conf/solrconfig.xml:
##########
@@ -29,7 +29,7 @@
<luceneMatchVersion>${tests.luceneMatchVersion:LATEST}</luceneMatchVersion>
- <updateHandler class="solr.DirectUpdateHandler2">
+ <updateHandler class="solr.DirectUpdateHandler2"
aggregateNodeLevelMetricsEnabled="true">
Review Comment:
These aggregation metrics were added to this but surprisingly never tested?
I added to the existing aggregation test to check for at least one of these
metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
