dsmiley commented on PR #3734: URL: https://github.com/apache/solr/pull/3734#issuecomment-3449103614
I'm running Solr main branch today and I'm second guessing my naming recommendation here to change solr_core to solr_node just because it's aggregated. It's _still_ fundamentally, core related information; these aren't node handler metrics (which already exist for the admin handlers). Couldn't we differentiate merely by labels/attributes? It may be a little awkward to filter based on the absence of a core attribute... but this is an advanced opt-in feature anyway. If the user chooses aggregate and core level, I could imagine adding a special `core=__node` value to aid in differentiating. But that could even come later; deferred till there's interest. (I'm happy to do the work of any rename, if we agree to one) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
