dsmiley commented on code in PR #3988:
URL: https://github.com/apache/solr/pull/3988#discussion_r2654363696
##########
solr/core/src/test/org/apache/solr/handler/ReplicationTestHelper.java:
##########
@@ -62,14 +61,9 @@ public final class ReplicationTestHelper {
+ FileSystems.getDefault().getSeparator();
public static JettySolrRunner createAndStartJetty(SolrInstance instance)
throws Exception {
- Files.copy(
- SolrTestCaseJ4.TEST_HOME().resolve("solr.xml"),
- Path.of(instance.getHomeDir(), "solr.xml"),
- StandardCopyOption.REPLACE_EXISTING);
- Properties nodeProperties = new Properties();
- nodeProperties.setProperty("solr.data.dir", instance.getDataDir());
Review Comment:
I at least checked where SolrInstance is used, data dir is the default so,
indeed, at least where SolrInstance is used (like here), we don't need to relay
it to "solr.data.dir".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
