dsmiley commented on code in PR #3988:
URL: https://github.com/apache/solr/pull/3988#discussion_r2654769060
##########
solr/core/src/test/org/apache/solr/security/BasicAuthStandaloneTest.java:
##########
@@ -54,8 +53,6 @@ public class BasicAuthStandaloneTest extends SolrTestCaseJ4 {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private static final Path ROOT_DIR = TEST_HOME();
- private static final Path CONF_DIR =
- ROOT_DIR.resolve("configsets").resolve("configset-2").resolve("conf");
Review Comment:
Lets not change this in this PR.
"collection1" is the default, not "configset-1". It is an unfortunate
kitchen-sink, with many tests using it. I'd rather see tests use one of
several basic / standard configs without any quirks and then *if needed* modify
it at runtime using config edit API or another approach on the fly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
