dsmiley commented on code in PR #4065:
URL: https://github.com/apache/solr/pull/4065#discussion_r2708535041
##########
solr/core/src/java/org/apache/solr/servlet/CoreContainerAwareHttpFilter.java:
##########
@@ -29,11 +29,10 @@
public abstract class CoreContainerAwareHttpFilter extends HttpFilter {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
- private CoreContainerProvider containerProvider;
Review Comment:
why?
##########
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:
##########
@@ -187,21 +181,6 @@ private void init(ServletContext servletContext) {
coresInit = createCoreContainer(computeSolrHome(servletContext),
extraProperties);
- SolrZkClient zkClient = null;
Review Comment:
glad to see this stuff gone from here
##########
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java:
##########
@@ -478,6 +485,13 @@ public SolrDispatchFilter getSolrDispatchFilter() {
return (SolrDispatchFilter) dispatchFilter.getFilter();
}
+ /**
+ * @return the {@link SolrDispatchFilter} for this node
+ */
+ public RateLimitFilter getSolrRateLimitFilter() {
Review Comment:
who calls this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
