dsmiley commented on code in PR #4065:
URL: https://github.com/apache/solr/pull/4065#discussion_r2709490942
##########
solr/core/src/java/org/apache/solr/servlet/CoreContainerAwareHttpFilter.java:
##########
@@ -29,11 +29,10 @@
public abstract class CoreContainerAwareHttpFilter extends HttpFilter {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
- private CoreContainerProvider containerProvider;
Review Comment:
I'm fairly confident we can depend on a "happens-before" relationship with
respect to init() occurring before requests are being processed. Are there any
particular tests / patterns that concern you?
I don't like making something volatile because there's a slight shred of
doubt... and then not documenting that shred of doubt. New eyes will see the
code and draw a bad lesson -- OMG we can't trust that init() finishes first?!
The sky is falling!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
