jvanneman commented on code in PR #3992: URL: https://github.com/apache/solr/pull/3992#discussion_r2724442574
########## changelog/unreleased/SOLR-18051-fix-double-registration-bug.yml: ########## @@ -0,0 +1,8 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc +title: Fix phaser/semaphore double registration bug in HttpJettySolrClient Review Comment: Updated! Github complained about merge conflicts so i pulled in the latest changes with a rebase, this seemed better for a clean git history but does require a force push which you mentioned in my other PR not to do. please let me know if i should do a merge commit next time, the clean git history seemed better though here. One of the tests was [failing in the last build](https://github.com/apache/solr/actions/runs/20623287668/job/60689620063?pr=3992) but passes locally for me, i don't believe these are related to my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
