jvanneman commented on code in PR #3992: URL: https://github.com/apache/solr/pull/3992#discussion_r2724500330
########## changelog/unreleased/SOLR-18051-fix-double-registration-bug.yml: ########## @@ -0,0 +1,8 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc +title: Fix phaser/semaphore double registration bug in HttpJettySolrClient Review Comment: makes sense, i think as long as the project is consistent either are fine. i have a slight preference towards a rebase because when reviewing PRs myself i will pull down the branch and run a `git log` to see what the author has done and it's a little easier for me when all of their commits are stacked on top. but both are workable, will merge next time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
