dsmiley commented on code in PR #4073: URL: https://github.com/apache/solr/pull/4073#discussion_r2726313190
########## solr/core/src/java/org/apache/solr/response/BuiltInResponseWriters.java: ########## Review Comment: honestly, this field needs no javadocs at all. It's private and nobody is going to read these javadocs to learn about Solr's response writers. If you feel a modicum of javadocs are needed on each one, then add to the javadocs of these classes (which probably already have docs), not here. ########## changelog/unreleased/admin-response-writers-minimal-set.yml: ########## @@ -1,22 +1,6 @@ # See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc -title: Introduce minimal ADMIN_RESPONSE_WRITERS for admin/container-level requests. Admin requests now use a minimal set of 6 response writers (javabin, json, xml, prometheus, openmetrics, standard) instead of the full 14-writer DEFAULT_RESPONSE_WRITERS map. Core-specific requests continue to use ImplicitPlugins.json with ConfigOverlay support. +title: Introduce minimal set of request writers for node/container-level requests. Core-specific request writers now leverage ImplicitPlugins.json for creation. type: changed Review Comment: no; "other" since it's a refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
