epugh commented on PR #4073: URL: https://github.com/apache/solr/pull/4073#issuecomment-3806090951
> At the risk of sounding dumb - I feel like I'm missing the "why" of this change. What benefit does this provide to users or developers? > > Is it about removing hardcoding to more things clearer and more explicit? Removing hardcoding to unify configuration locations? Removing hardcoding to make it easier for folks to disable certain requesthandlers or requestwriters or whatever? > > Is it about pulling code out of CoreContainer (where much of the hardcoding is) to make maintenance easier on devs? > > Something else entirely? Yes. Yes. Yes. Yes. ;-) The part you don't see is the next PR where if a configset has a `ImplicitPlugins.json` then it is used instead of the default `ImplicitPlugins.json`. And we are making it clearer that `ImplicitPlugins.json` is specfic to a configset and not a node/container scoped file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
