epugh opened a new pull request, #4101: URL: https://github.com/apache/solr/pull/4101
https://issues.apache.org/jira/browse/SOLR-18038 # Description Migrate from LocalSolrQueryRequest to SolrQueryRequestBase by making `SolrQueryRequestBase` no longer abstract and including all functionality previously unique to `LocalSolrQueryRequest` # Solution Beyond the direct conversion, I've also looked for places we used a `NamedList` and replaced them with `ModifiableSolrParams`. There is this "six parameter" pattern that remains, primarily in tests, but it's done via `ModifiableSolrParams` method. Some anonymous subclasses of `SolrQueryRequestBase` are now explicit. `CSVRequest` was trivial and could be removed now that `SolrQueryRequestBase` isn't abstract. _BIG QUESTION: SHould we rename `SolrQueryRequestBase` to just `SolrQueryRequest` and eliminate the interface `SolrQueryRequest`? # Tests I've re-run the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
