epugh commented on code in PR #4101:
URL: https://github.com/apache/solr/pull/4101#discussion_r2778379800
##########
solr/test-framework/src/java/org/apache/solr/util/TestHarness.java:
##########
@@ -190,6 +192,34 @@ public static NodeConfig buildTestNodeConfig(Path
solrHome) {
.build();
}
+ /**
+ * Utility method to build SolrParams from individual query components. This
is a convenience
+ * method for legacy code that needs to construct params from separate
query, qtype, start, limit,
+ * and additional args.
+ *
+ * @param query the query string (added as "q" param)
+ * @param qtype the query type (added as "qt" param)
+ * @param start the start offset (added as "start" param)
+ * @param limit the row limit (added as "rows" param)
+ * @param args additional parameters as a map
+ * @return SolrParams containing all the specified parameters
+ */
Review Comment:
turns out this is only used by the `ConvertedLegacyTest` (i had dealt with
all the other cases) so I moved it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
