janhoy commented on code in PR #4098:
URL: https://github.com/apache/solr/pull/4098#discussion_r2776333156
##########
gradle/libs.versions.toml:
##########
@@ -361,18 +356,18 @@ flexmark-extensions-abbreviation = { module =
"com.vladsch.flexmark:flexmark-ext
flexmark-extensions-attributes = { module =
"com.vladsch.flexmark:flexmark-ext-attributes", version.ref = "flexmark" }
flexmark-extensions-autolink = { module =
"com.vladsch.flexmark:flexmark-ext-autolink", version.ref = "flexmark" }
flexmark-flexmark = { module = "com.vladsch.flexmark:flexmark", version.ref =
"flexmark" }
-google-api-gax = { module = "com.google.api:gax", version.ref =
"google-api-gax" }
+google-api-gax = { module = "com.google.api:gax" }
# @keep transitive dependency for version alignment
google-api-grpc-proto = { module =
"com.google.api.grpc:proto-google-common-protos", version.ref =
"google-api-grpc-proto" }
-google-auth-credentials = { module =
"com.google.auth:google-auth-library-credentials", version.ref = "google-auth" }
-google-auth-oauth2http = { module =
"com.google.auth:google-auth-library-oauth2-http", version.ref = "google-auth" }
+google-auth-credentials = { module =
"com.google.auth:google-auth-library-credentials" }
+google-auth-oauth2http = { module =
"com.google.auth:google-auth-library-oauth2-http" }
# @keep transitive dependency for version alignment
google-autovalue-annotations = { module =
"com.google.auto.value:auto-value-annotations", version.ref =
"google-autovalue" }
google-cloud-bom = { module = "com.google.cloud:google-cloud-bom", version.ref
= "google-cloud-bom" }
-google-cloud-core = { module = "com.google.cloud:google-cloud-core",
version.ref = "google-cloud-core" }
-google-cloud-corehttp = { module = "com.google.cloud:google-cloud-core-http",
version.ref = "google-cloud-core" }
-google-cloud-nio = { module = "com.google.cloud:google-cloud-nio", version.ref
= "google-cloud-nio" }
-google-cloud-storage = { module = "com.google.cloud:google-cloud-storage",
version.ref = "google-cloud-storage" }
Review Comment:
I was able to remove version ref (and also version declaration above) for
seven libs covered by this BOM. It all seems to compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
