[
https://issues.apache.org/jira/browse/SOLR-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057010#comment-18057010
]
David Smiley commented on SOLR-18106:
-------------------------------------
This one will not be so straight-forward. It's there because of the
coordinator feature. I sort of hate the method (so I deprecated it) because
getting a cloud descriptor happens in tons of places... and only one place
(HttpShardHandler) is calling this specific way to get it. So it's a
questionable design smell. But I don't have a better design in mind. I
suspect there are other places that _should_ be calling this but aren't, and
thus work suboptimally/fail in the coordinator mode. I guess I'd rather just
see it un-deprecated, and a small explanation present to explain why it exists.
> Remove SolrQueryRequest.getCloudDescriptor
> ------------------------------------------
>
> Key: SOLR-18106
> URL: https://issues.apache.org/jira/browse/SOLR-18106
> Project: Solr
> Issue Type: Sub-task
> Reporter: Eric Pugh
> Priority: Major
>
> This method has been deprecated, is only called in two places, and is easily
> inlined.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
