[
https://issues.apache.org/jira/browse/SOLR-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057058#comment-18057058
]
Eric Pugh commented on SOLR-18106:
----------------------------------
okay, we can do that. I do have some follow up commits that may change your
mind on being able to remove it.
For what it's worth, all the tests passed after I made the change. Then I did
some more changes based on copilot feedback, and the tests pass and now I am
running the bats integration tests.
Seems like if the unit and bats test all pass, then my changes are a candidate
for moving forward.
I think we should be deprecating things with a clear plan of why we are
deprecating and where we are going. I don't love the bare @Deprecated tags
with no indicating plan that we have. Just deprecating things because they
"are not good" doesn't really help the person coming along a few years later!
There are LOTS of things in Solr I might "deprecate" because I don't think they
are great ;).
> Remove SolrQueryRequest.getCloudDescriptor
> ------------------------------------------
>
> Key: SOLR-18106
> URL: https://issues.apache.org/jira/browse/SOLR-18106
> Project: Solr
> Issue Type: Sub-task
> Reporter: Eric Pugh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This method has been deprecated, is only called in two places, and is easily
> inlined.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
