arup-chauhan commented on code in PR #4139:
URL: https://github.com/apache/solr/pull/4139#discussion_r2814488761
##########
solr/core/src/java/org/apache/solr/search/vector/KnnQParser.java:
##########
@@ -133,10 +133,11 @@ public Query parse() throws SyntaxError {
final Integer filteredSearchThreshold =
localParams.getInt(FILTERED_SEARCH_THRESHOLD);
// check for parent diversification logic...
- final String parentsFilterQuery = localParams.get(PARENTS_PRE_FILTER);
+ final String[] parentsFilterQueries =
localParams.getParams(PARENTS_PRE_FILTER);
final String allParentsQuery = localParams.get(CHILDREN_OF);
- boolean isDiversifyingChildrenKnnQuery = null != parentsFilterQuery ||
null != allParentsQuery;
Review Comment:
Hey, I earlier ran the `gradlew tidy` and ran it again.
Here is the dump
--->>
./gradlew tidy
git status --short
git diff --
solr/core/src/java/org/apache/solr/search/vector/KnnQParser.java
BUILD SUCCESSFUL in 27s
67 actionable tasks: 58 executed, 9 up-to-date
--->>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
