epugh opened a new pull request, #4172: URL: https://github.com/apache/solr/pull/4172
`RenameCoreAPI.java` was the last remnant of the old `@EndPoint`/`@Command` V2 API style for core renaming. The JAX-RS implementation (`RenameCore.java`, `RenameCoreApi.java`, `RenameCoreRequestBody.java`) already existed and was fully wired into `CoreAdminHandler.getJerseyResources()` and `CoreAdminOperation.RENAME_OP` — the old class was dead production code only referenced in a mock-based test. ## Changes - **Deleted** `RenameCoreAPI.java` — superseded by `RenameCore.java` - **Updated** `V2CoreAPIMappingTest` — removed `RenameCoreAPI` registration and its mock-based `testRenameCoreAllParams` test - **Added** `RenameCoreAPITest` — unit tests for `RenameCore` using `SolrJettyTestRule` (no mocks, no `initCore`), following the pattern of `ShowFileRequestHandlerTest` Tests cover: same-name early return, missing request body, and missing `to` parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
