epugh commented on code in PR #4172: URL: https://github.com/apache/solr/pull/4172#discussion_r2874888090
########## solr/core/src/test/org/apache/solr/handler/admin/api/RenameCoreAPITest.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.admin.api; + +import static org.apache.solr.core.CoreContainer.ALLOW_PATHS_SYSPROP; + +import java.nio.charset.StandardCharsets; +import org.apache.solr.SolrTestCaseJ4; +import org.apache.solr.client.api.model.SolrJerseyResponse; +import org.apache.solr.client.solrj.RemoteSolrException; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.request.CoresApi; +import org.apache.solr.client.solrj.request.GenericV2SolrRequest; +import org.apache.solr.common.SolrException; +import org.apache.solr.common.util.EnvUtils; +import org.apache.solr.util.ExternalPaths; +import org.apache.solr.util.SolrJettyTestRule; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Test; + +/** + * The success case and the missing-parameter error case use the generated {@link + * CoresApi.RenameCore} request type, asserting directly on {@link + * SolrJerseyResponse#responseHeader} status and {@link + * org.apache.solr.client.api.model.ErrorInfo#msg} because the generated typed client uses {@code + * JacksonDataBindResponseParser}, which does not yet propagate errors as exceptions (SOLR-17549). + * + * <p>The missing-body error case uses {@link GenericV2SolrRequest} with an explicit {@code "null"} + * JSON body, because {@link CoresApi.RenameCore} always serializes a request body and therefore + * cannot represent a truly absent body. The standard response parser used by {@link + * GenericV2SolrRequest} does propagate 4xx responses as {@link RemoteSolrException}s. + * + * <p>TODO: Deal with this when generated code does properly throw an exception! + */ +public class RenameCoreAPITest extends SolrTestCaseJ4 { + + @ClassRule public static SolrJettyTestRule solrTestRule = new SolrJettyTestRule(); + + @BeforeClass + public static void beforeTest() throws Exception { + EnvUtils.setProperty( + ALLOW_PATHS_SYSPROP, ExternalPaths.SERVER_HOME.toAbsolutePath().toString()); + solrTestRule.startSolr(createTempDir()); + solrTestRule + .newCollection(DEFAULT_TEST_CORENAME) + .withConfigSet(ExternalPaths.DEFAULT_CONFIGSET) + .create(); + } + + @Test + public void testRenameCoreToSameNameSucceeds() throws Exception { + CoresApi.RenameCore renameRequest = new CoresApi.RenameCore(DEFAULT_TEST_CORENAME); + renameRequest.setTo(DEFAULT_TEST_CORENAME); + SolrJerseyResponse response = renameRequest.process(solrTestRule.getAdminClient()); + assertEquals(0, response.responseHeader.status); + } + + @Test + public void testMissingRequestBodyThrowsError() { + // Sending JSON "null" as the body causes Jersey to deserialize it to a null requestBody, + // triggering the handler's "Required request-body is missing" guard. + GenericV2SolrRequest renameRequest = + new GenericV2SolrRequest( Review Comment: it does, but the typed one doesn't raise the nice error.. I also thought maybe having both ways tested was of some value? 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
