dsmiley commented on code in PR #4168:
URL: https://github.com/apache/solr/pull/4168#discussion_r2867793483
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##########
@@ -462,13 +462,7 @@ private void implTransform(SolrDocument doc, int docid,
DocIterationInfo docInfo
private static class LoggingModel extends LTRScoringModel {
public LoggingModel(String name, String featureStoreName, List<Feature>
allFeatures) {
- this(
- name,
- Collections.emptyList(),
- Collections.emptyList(),
- featureStoreName,
- allFeatures,
- Collections.emptyMap());
+ this(name, List.of(), List.of(), featureStoreName, allFeatures,
Collections.emptyMap());
Review Comment:
you know `emptyMap` is the next target Eric :-)
In fact you could reasonably increase the scope of the JIRA issue to cover
the others.
##########
solr/core/src/java/org/apache/solr/search/vector/AbstractVectorQParserBase.java:
##########
@@ -164,15 +163,15 @@ protected Query getFilterQuery() throws SolrException,
SyntaxError {
try {
// Start by assuming we wrap all global filters,
// then adjust our list based on include/exclude tag params
- List<Query> globalFQs = QueryUtils.parseFilterQueries(req);
+ List<Query> globalFQs = new
ArrayList<>(QueryUtils.parseFilterQueries(req));
Review Comment:
copy isn't needed anymore
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##########
@@ -462,13 +462,7 @@ private void implTransform(SolrDocument doc, int docid,
DocIterationInfo docInfo
private static class LoggingModel extends LTRScoringModel {
public LoggingModel(String name, String featureStoreName, List<Feature>
allFeatures) {
- this(
Review Comment:
I love seeing the conciseness cut downs on lines, as seen here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
