dsmiley commented on code in PR #4193:
URL: https://github.com/apache/solr/pull/4193#discussion_r2900101838
##########
solr/core/src/java/org/apache/solr/cli/ConfigSetUploadTool.java:
##########
@@ -96,6 +101,22 @@ public void runImpl(CommandLine cli) throws Exception {
+ " to ZooKeeper at "
+ zkHost);
FileTypeMagicUtil.assertConfigSetFolderLegal(confPath);
+ Files.walkFileTree(
Review Comment:
Come to think of it, I disagree with limiting what the CLI tool can upload
on principle. This is a false protection -- if you can use the CLI tool (to
touch zookeeper, then you already have permission to do so by your ability to
do that very thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
