dsmiley commented on code in PR #4193:
URL: https://github.com/apache/solr/pull/4193#discussion_r2955060445
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java:
##########
@@ -345,13 +342,6 @@ public FileVisitResult visitFile(Path file,
BasicFileAttributes attrs)
filenameExclusions);
return FileVisitResult.CONTINUE;
}
- if (isFileForbiddenInConfigSets(filename)) {
Review Comment:
What you link to -- in ZkConfigSetService -- *that* is the protection that
matters. It's specific to a ConfigSetService impl, and it's API connected, so
it's worth protecting.
ZkMaintenanceUtils is some random ZK utility things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
