r4mercur commented on PR #4175: URL: https://github.com/apache/solr/pull/4175#issuecomment-4025336706
You are right and i tried now to understand the real impact of this bug. With looking at the code: The method seems to be deprecated anyway -> usage should be done via node roles like the log says at line 2616 ZkController.class. Users probably are using this rarely and it seems like even when using it the buggy behaviour would only lead to silent failure of the preferred overseer role assignment. So the question would be: Wouldn't it make more sense to remove this feature completely ? (I didn't check, if its used anywhere internally) Then it would be wise to close this PR and create a new ticket for removing the existance of this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
