dsmiley commented on PR #4175: URL: https://github.com/apache/solr/pull/4175#issuecomment-4043348789
My reading of the code (aided by a few runs of the debugger in NodeRolesTest and OverseerRolesTest) is that *if* a node is started with system properties reflecting that it's the preferred Overseer (this is the new/recommended way), *then*, it will call `org.apache.solr.cloud.ZkController#setPreferredOverseer` to actively take over. But persists=false... on the receiving end, `OverseerRoleCmd` *ignores* whatever _node_ is set to and triggers the overseer prioritization thread. I haven't read how that in turn knows who *should* be the overseer. Meaning, I'm not yet sure if this is an oversight/gap, or the caller should not pass "node" in the first place, as it's misleading (when persist=true). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
