openworld-maker opened a new pull request, #4215: URL: https://github.com/apache/solr/pull/4215
## Description This PR addresses SOLR-18123 by reducing the need for tests to explicitly set `ALLOW_PATHS_SYSPROP` (`solr.security.allow.paths`). Changes: - set a test-framework default for `solr.security.allow.paths` in `SolrTestCase` when not already defined, using the test framework derived server home path - keep explicit behavior unchanged when the property is already set - add `TestFrameworkAllowPathsTest` to verify the default is applied and includes the expected test path - remove redundant explicit `ALLOW_PATHS_SYSPROP` setup from tests that only needed it to read standard test-owned paths No production security defaults are changed. ## Testing Passed targeted tests for all touched classes: - `./gradlew test --continue --tests org.apache.solr.TestFrameworkAllowPathsTest --tests org.apache.solr.client.solrj.apache.BasicHttpSolrClientTest --tests org.apache.solr.client.solrj.apache.ConcurrentUpdateSolrClientBadInputTest --tests org.apache.solr.client.solrj.apache.ConcurrentUpdateSolrClientTest --tests org.apache.solr.client.solrj.apache.HttpSolrClientConPoolTest --tests org.apache.solr.handler.admin.ShowFileRequestHandlerTest --tests org.apache.solr.handler.admin.api.RenameCoreAPITest --tests org.apache.solr.handler.component.DistributedDebugComponentTest --tests org.apache.solr.response.TestPrometheusResponseWriter --tests org.apache.solr.client.solrj.jetty.ConcurrentUpdateJettySolrClientBadInputTest --tests org.apache.solr.client.solrj.jetty.HttpJettySolrClientCompatibilityTest --tests org.apache.solr.client.solrj.jetty.HttpJettySolrClientProxyTest --tests org.apache.solr.client.solrj.SolrExampleTests --tests org.apache.solr.client.solrj.TestBatchUpdate --tests org.a pache.solr.client.solrj.TestSolrJErrorHandling --tests org.apache.solr.client.solrj.impl.ConcurrentUpdateSolrClientTestBase --tests org.apache.solr.client.solrj.impl.HttpSolrClientBadInputTest --tests org.apache.solr.client.solrj.impl.HttpSolrClientTestBase --tests org.apache.solr.client.solrj.impl.LBHttpSolrClientBadInputTest --tests org.apache.solr.client.solrj.response.InputStreamResponseParserTest --tests org.apache.solr.client.solrj.response.TestSuggesterResponse` Also ran: - `./gradlew tidy` - `./gradlew check` In this local sandbox, full `check` is blocked by environment-level OS permission restrictions in unrelated CLI/process-management tests (`sysctl` access), while affected-module tests for this change pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
