epugh commented on code in PR #4215:
URL: https://github.com/apache/solr/pull/4215#discussion_r2937556596
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCase.java:
##########
@@ -148,6 +149,28 @@ public static void beforeSolrTestCase() {
ExternalPaths.DEFAULT_CONFIGSET);
}
+ final String allowPaths =
EnvUtils.getProperty(CoreContainer.ALLOW_PATHS_SYSPROP);
Review Comment:
I think this makes sense, but would love @dsmiley to weigh in!
##########
solr/core/src/test/org/apache/solr/handler/admin/api/RenameCoreAPITest.java:
##########
@@ -47,10 +45,7 @@ public class RenameCoreAPITest extends SolrTestCaseJ4 {
@ClassRule public static SolrJettyTestRule solrTestRule = new
SolrJettyTestRule();
@BeforeClass
- public static void beforeTest() throws Exception {
- EnvUtils.setProperty(
- ALLOW_PATHS_SYSPROP,
ExternalPaths.SERVER_HOME.toAbsolutePath().toString());
- solrTestRule.startSolr(createTempDir());
+ public static void beforeTest() throws Exception {
solrTestRule.startSolr(createTempDir());
Review Comment:
this formatting line looks werid, really surpirse `tidy` didn't wrap it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
